Hover styling for dataset in 'dataset' mode - #6527
Conversation
Sorry, something went wrong.
|
I just had an idea. What if we call _resolveDatasetElementOptions again, but with a new argument denoting that the dataset is currently being hovered? Then we would support all chart types instead of just line and it would be scriptable by the user. We could automatically look for options of the same name prefixed with hover and give them priority. We could also add hover: true to the context so that it can be scriptable by the user |
Sorry, something went wrong.
|
I think it'd be nice to update setHoverStyle to use _resolveDataElementOptions similar to the way setDatasetHoverStyle works I also think some of the other docs need to be updated as well like bar chart now that this is implemented generically. Maybe we can document hover generically? |
Sorry, something went wrong.
Agreed, but its not quite in the scope of this PR
Bar does not utilize dataset element, so this does not apply there. Not quite sure how to document hover generically. |
Sorry, something went wrong.
| | [`borderWidth`](#line-styling) | `number` | Yes | - | `3` | ||
| | [`cubicInterpolationMode`](#cubicinterpolationmode) | `string` | Yes | - | `'default'` | ||
| | [`fill`](#line-styling) | <code>boolean|string</code> | Yes | - | `true` | ||
| | [`hoverBackgroundColor`](#line-styling) | [`Color`](../general/colors.md) | Yes | - | `undefined` |
There was a problem hiding this comment.
Should we document hoverCubicInterpolationMode and hoverFill?
Sorry, something went wrong.
There was a problem hiding this comment.
Neither of those work. We are not going through update on hover, just updating the model with options and then render.
So bezier control points don't get updated.
I did not investigate why hoverFill does not work.
Sorry, something went wrong.
* Hover styling for dataset in 'dataset' mode
Dataset level hover styles for dataset mode.
Pen
Closes: #2136
Partially solves: #3880 (hover only triggered by points still, not filled area as requested)