Support reverse binary operations - #1
Open
christabella wants to merge 1 commit into
Open
christabella wants to merge 1 commit into
christabella wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
lostmsu
reviewed
Dec 28, 2020
Comment thread
src/runtime/methodbinder.cs
Comment on lines
+378
to
+386
| // Postprocessing to extend margs. | ||
| var margsTemp = new object[2]; | ||
| // If forward, the bound instance is the left operand. | ||
| int boundOperandIndex = isForward ? 0 : 1; | ||
| // If forward, the passed instance is the right operand. | ||
| int passedOperandIndex = isForward ? 1 : 0; | ||
| margsTemp[boundOperandIndex] = co.inst; | ||
| margsTemp[passedOperandIndex] = margs[0]; | ||
| margs = margsTemp; |
Copy link
Copy Markdown
There was a problem hiding this comment.
What about unary operators (e.g. -a, !a)?
Sorry, something went wrong.
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Reverse operator methods
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.