CI - Add cargo ci dep-check and remove unused deps - #5703
Draft
clockwork-labs-bot wants to merge 41 commits into
Draft
CI - Add cargo ci dep-check and remove unused deps#5703clockwork-labs-bot wants to merge 41 commits into
clockwork-labs-bot wants to merge 41 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This reverts commit 2c10c76.
…rgo-ci-merge-5687 # Conflicts: # tools/ci/README.md # tools/ci/src/main.rs
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
clockwork-labs-bot
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
August 9, 2026 18:05
bfops
reviewed
Aug 9, 2026
Comment thread
tools/ci/commands/dep-check/src/main.rs
Outdated
bfops
reviewed
Aug 9, 2026
Comment thread
.github/workflows/ci.yml
Outdated
bfops
reviewed
Aug 9, 2026
Comment thread
sdks/rust/tests/connect_disconnect_client/Cargo.toml
Outdated
bfops
reviewed
Aug 9, 2026
Comment thread
sdks/rust/tests/event-table-client/Cargo.toml
Outdated
bfops
reviewed
Aug 9, 2026
Comment thread
sdks/rust/tests/procedural-view-pk-client/Cargo.toml
Outdated
bfops
reviewed
Aug 9, 2026
Comment thread
sdks/rust/tests/procedure-concurrency-client/Cargo.toml
Outdated
bfops
reviewed
Aug 9, 2026
Comment thread
sdks/rust/tests/procedure-client/Cargo.toml
Outdated
bfops
reviewed
Aug 9, 2026
Comment thread
sdks/rust/tests/test-client/Cargo.toml
Outdated
bfops
reviewed
Aug 9, 2026
Comment thread
sdks/rust/tests/view-client/Cargo.toml
Outdated
bfops
reviewed
Aug 9, 2026
Comment thread
sdks/rust/tests/view-pk-client/Cargo.toml
Outdated
bfops
reviewed
Aug 9, 2026
Comment thread
sdks/rust/Cargo.toml
Outdated
bfops
reviewed
Aug 9, 2026
Comment thread
templates/chat-console-rs/Cargo.toml
Outdated
bfops
reviewed
Aug 9, 2026
Comment thread
templates/chat-console-rs/spacetimedb/Cargo.toml
| [dependencies] | ||
| spacetimedb = { path = "../../../crates/bindings" } | ||
| log.workspace = true | ||
| log = "0.4" |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
note for human reviewers: templates can't depend on workspace versions because they're specifically designed to be copied out of the workspace for users by the CLI. Other templates (e.g. templates/basic-rs) already do things this way.
Sorry, something went wrong.
bfops
reviewed
Aug 12, 2026
Comment thread
sdks/rust/Cargo.toml
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
# Conflicts: # Cargo.lock # Cargo.toml # tools/ci/Cargo.toml # tools/ci/README.md # tools/ci/commands/cla-assistant/src/main.rs # tools/ci/commands/cli-docs/src/main.rs # tools/ci/commands/codeowners-check/src/main.rs # tools/ci/commands/coordinate-internal-tests/src/main.rs # tools/ci/commands/docs/Cargo.toml # tools/ci/commands/docs/src/main.rs # tools/ci/commands/global-json-policy/Cargo.toml # tools/ci/commands/global-json-policy/src/main.rs # tools/ci/commands/keynote-bench/Cargo.toml # tools/ci/commands/keynote-bench/src/main.rs # tools/ci/commands/lint/Cargo.toml # tools/ci/commands/lint/src/main.rs # tools/ci/commands/publish-checks/Cargo.toml # tools/ci/commands/publish-checks/src/main.rs # tools/ci/commands/smoketests/Cargo.toml # tools/ci/commands/smoketests/src/main.rs # tools/ci/commands/test/Cargo.toml # tools/ci/commands/test/src/main.rs # tools/ci/commands/typescript-test/Cargo.toml # tools/ci/commands/typescript-test/src/main.rs # tools/ci/commands/update-flow/src/main.rs # tools/ci/commands/version-upgrade-check/Cargo.toml # tools/ci/commands/version-upgrade-check/src/main.rs # tools/ci/commands/wasm-bindings/Cargo.toml # tools/ci/commands/wasm-bindings/src/main.rs # tools/ci/src/ci_docs.rs # tools/ci/src/main.rs
clockwork-labs-bot
requested review from
joshua-spacetime and
rekhoff
as code owners
August 14, 2026 15:14
bfops
reviewed
Aug 14, 2026
Comment thread
.github/workflows/ci.yml
Outdated
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
joshua-spacetime
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Why does this have to be automated?
Sorry, something went wrong.
bfops
marked this pull request as draft
August 14, 2026 15:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds cargo ci dep-check, stacked on #5687, to run cargo-machete from the repository root.
The command forwards any extra arguments to cargo-machete, so manual runs can use flags like --with-metadata or pass explicit paths.
The Lints workflow installs cargo-machete with --locked and runs cargo ci dep-check after cargo ci lint.
API and ABI breaking changes
None.
Expected complexity level and risk
Testing