LITE-31369: Fix AsyncConnectClient ignoring environment proxies - #82
Merged
qarlosh merged 1 commit intoNov 20, 2024
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
Carlos Herrero seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, something went wrong.
qarlosh
commented
Nov 15, 2024
Comment thread
connect/client/fluent.py
| httpx.AsyncHTTPTransport(verify=_SSL_CONTEXT), | ||
| ), | ||
| ) | ||
| transport = _ASYNC_TRANSPORTS.get(self.endpoint) |
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
also fixed how transports are reused, because a new transport object was created every time even if the existing one for the endpoint was used.
Sorry, something went wrong.
r-s11v
self-requested a review
November 19, 2024 15:32
r-s11v
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.