Switch to blob().text() for faster fetch parsing - #80
Closed
Ulternae wants to merge 1 commit into
Closed
Ulternae wants to merge 1 commit into
Ulternae wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Please set a semver versioning label of either major, minor, or patch on this pull request. |
Sorry, something went wrong.
Ulternae
marked this pull request as draft
April 4, 2026 19:10
Ulternae
marked this pull request as ready for review
April 4, 2026 19:10
Ulternae
marked this pull request as draft
April 4, 2026 19:11
Ulternae
marked this pull request as ready for review
April 4, 2026 19:13
Copy link
Copy Markdown
Collaborator
|
Will close this PR, since I'm reviewing #76 which has the same fix. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves download speed measurement accuracy by replacing response.text() with response.blob().text().
response.text() was introducing significant JS-side backpressure, which throttled the effective TCP throughput and caused download measurements to be much lower than expected. Using response.blob().text() avoids that issue and produces more accurate results.
Original PR : dmeremianina
Semver label: patch
It looks like there are no available semver labels, or I don’t have permission to add them. Could a maintainer please add the patch label? This PR is a non-breaking performance improvement.