FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[build] Prepare workerd for explicit libc++ linkage by KirillTim · Pull Request #7025 · cloudflare/workerd · GitHub

/ workerd Public

[build] Prepare workerd for explicit libc++ linkage - #7025

Merged
KirillTim merged 1 commit into
mainfrom
ktimofeev/bazel-hiremtic-libcxx
Aug 24, 2026
ConversationCommits (1)ChecksFiles changed
Merged

[build] Prepare workerd for explicit libc++ linkage#7025
KirillTim merged 1 commit into
mainfrom
ktimofeev/bazel-hiremtic-libcxx

Conversation

KirillTim commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Edgeworker now supplies libc++ through link_extra_libs.
For "rust_" targets it is supplied via "@@//deps:rust_runtime".

Fix helloworld_compile_test to work with $ORIGIN relative RUNPATH.

Release note: None

KirillTim requested review from a team as code owners August 16, 2026 22:50

ask-bonk Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

2 similar comments

ask-bonk Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

ask-bonk Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

ask-bonk Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

@KirillTim Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

KirillTim force-pushed the ktimofeev/bazel-hiremtic-libcxx branch from 8da6ec0 to 6b80b22 Compare August 16, 2026 23:10

codspeed-hq Bot commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will improve performance by 11.59%

⚡ 1 improved benchmark
✅ 71 untouched benchmarks
⏩ 129 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ simpleStringBody[Response] 25.2 µs 22.6 µs +11.59%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing ktimofeev/bazel-hiremtic-libcxx (d7c1d6b) with main (de2058f)

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

npaun reviewed Aug 17, 2026
View reviewed changes
Comment thread build/BUILD.sqlite3 Outdated

npaun commented Aug 17, 2026

Copy link
Copy Markdown
Member

Seems reasonable - would like to discuss the overall motivation for this though.

KirillTim force-pushed the ktimofeev/bazel-hiremtic-libcxx branch from 6b80b22 to fc09d08 Compare August 17, 2026 11:55

fhanau commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Seems reasonable - would like to discuss the overall motivation for this though.

Yeah I think this merits some more discussion before moving forward with this approach – this adds complexity for every binary that doesn't use libc++, we should only do this if there's no better alternative. In particular, I think we can use LD_LIBRARY_PATH to avoid needing this.

KirillTim force-pushed the ktimofeev/bazel-hiremtic-libcxx branch from fc09d08 to 6361108 Compare August 20, 2026 12:20

codecov-commenter commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.83%. Comparing base (e442892) to head (3d642e9).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7025   +/-   ##
=======================================
  Coverage   67.83%   67.83%           
=======================================
  Files         458      458           
  Lines      130083   130083           
  Branches    21272    21272           
=======================================
  Hits        88239    88239           
  Misses      28932    28932           
  Partials    12912    12912

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

KirillTim force-pushed the ktimofeev/bazel-hiremtic-libcxx branch 4 times, most recently from 3881731 to 9350d1f Compare August 21, 2026 16:15

fhanau commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

LGTM otherwise

KirillTim force-pushed the ktimofeev/bazel-hiremtic-libcxx branch 2 times, most recently from 02fe6cb to 036db4b Compare August 24, 2026 16:48
[build] Prepare workerd for explicit libc++ linkage
3d642e9 
Edgeworker now supplies libc++ through link_extra_libs.
For "rust_" targets it is supplied via "@@//deps:rust_runtime".

Fix helloworld_compile_test to work with $ORIGIN relative RUNPATH.

Release note: None
KirillTim force-pushed the ktimofeev/bazel-hiremtic-libcxx branch from 036db4b to 3d642e9 Compare August 24, 2026 17:07
KirillTim merged commit 68459b7 into main Aug 24, 2026
21 checks passed
KirillTim deleted the ktimofeev/bazel-hiremtic-libcxx branch August 24, 2026 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fhanau fhanau left review comments
npaun npaun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL