FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CC-8419: make directory snapshot id optional by flakey5 · Pull Request #7039 · cloudflare/workerd · GitHub

/ workerd Public

CC-8419: make directory snapshot id optional - #7039

Merged
flakey5 merged 1 commit into
mainfrom
flakey5/CC-8419
Aug 20, 2026
ConversationCommits (1)ChecksFiles changed
Merged

CC-8419: make directory snapshot id optional#7039
flakey5 merged 1 commit into
mainfrom
flakey5/CC-8419

Conversation

flakey5 commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

If snapshot is empty, directory will just be prepared to be snapshotted upfront

Draft until internal mr merged

cc @spahl @rushilmehra

flakey5 requested review from a team as code owners August 17, 2026 21:28
flakey5 requested a review from emily-shen August 17, 2026 21:28

ask-bonk Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Model not found: cloudflare-ai-gateway/anthropic/claude-opus-4-6. Did you mean: anthropic/claude-opus-4.5, anthropic/claude-opus-4.6, anthropic/claude-opus-4.7?

github run

ask-bonk Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@flakey5 Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

flakey5 marked this pull request as draft August 17, 2026 21:42

This comment was marked as low quality.

Sign in to view

codecov-commenter commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.54962% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.49%. Comparing base (d8904e2) to head (0cbcdb5).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/workerd/api/container-test.c++ 88.33% 0 Missing and 14 partials ⚠️
src/workerd/api/container.c++ 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7039      +/-   ##
==========================================
+ Coverage   67.45%   67.49%   +0.03%     
==========================================
  Files         457      457              
  Lines      128015   128141     +126     
  Branches    20943    20964      +21     
==========================================
+ Hits        86355    86489     +134     
+ Misses      29002    28980      -22     
- Partials    12658    12672      +14

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jasnell reviewed Aug 17, 2026
View reviewed changes
Comment thread src/workerd/api/container-test.c++ Outdated
jasnell approved these changes Aug 17, 2026
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

FYI, AI-reviewer is wonky right now so likely won't get a result from that.

flakey5 marked this pull request as ready for review August 19, 2026 17:33
CC-8419: make directory snapshot id optional
0cbcdb5 
If snapshot is empty, directory will just be prepared to be snapshotted
upfront

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
flakey5 enabled auto-merge (squash) August 20, 2026 21:12
flakey5 merged commit 1162ae2 into main Aug 20, 2026
23 checks passed
flakey5 deleted the flakey5/CC-8419 branch August 20, 2026 21:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
gpanders gpanders approved these changes
dario-piotrowicz dario-piotrowicz approved these changes
emily-shen Awaiting requested review from emily-shen emily-shen is a code owner automatically assigned from cloudflare/wrangler

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL