[build] Fall back to scalar zlib on CPUs without SIMD ports - #7062
Open
Xeonacid wants to merge 1 commit into
Open
[build] Fall back to scalar zlib on CPUs without SIMD ports#7062Xeonacid wants to merge 1 commit into
Xeonacid wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
build/BUILD.zlib overlays Chromium zlib with ISA-specific SIMD defines and deps, but several select()s only list x86_64 and aarch64. Bazel analysis then fails on any other CPU because those configurable attributes have no matching condition. The SIMD libraries already no-op when their ADLER32_SIMD_*, INFLATE_CHUNK_SIMD_*, CRC32_* and DEFLATE_SLIDE_HASH_* defines are unset: the corresponding C files are empty translation units or the generic zlib sources are used instead. Add "//conditions:default": [] so those selects resolve, and skip the x86/ARM-only CRC SIMD deps on other CPUs. This does not enable RISC-V Vector (or other) zlib optimizations; it only unblocks a portable scalar build.
Copy link
Copy Markdown
|
All contributors have signed the CLA ✍️ ✅ |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I have read the CLA Document and I hereby sign the CLA |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build/BUILD.zlib overlays Chromium zlib with ISA-specific SIMD defines and deps, but several select()s only list x86_64 and aarch64. Bazel analysis then fails on any other CPU because those configurable attributes have no matching condition.
The SIMD libraries already no-op when their ADLER32_SIMD_, INFLATE_CHUNK_SIMD_, CRC32_* and DEFLATE_SLIDE_HASH_* defines are unset: the corresponding C files are empty translation units or the generic zlib sources are used instead. Add "//conditions:default": [] so those selects resolve, and skip the x86/ARM-only CRC SIMD deps on other CPUs.
This does not enable RISC-V Vector (or other) zlib optimizations; it only unblocks a portable scalar build.