FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[edge-preview-authenticated-proxy] Release WShim metrics migration by petebacondarwin · Pull Request #15224 · cloudflare/workers-sdk · GitHub

[edge-preview-authenticated-proxy] Release WShim metrics migration - #15224

Merged
petebacondarwin merged 2 commits into
mainfrom
fix/edge-preview-proxy-metrics-release
Aug 16, 2026
Merged

[edge-preview-authenticated-proxy] Release WShim metrics migration#15224
petebacondarwin merged 2 commits into
mainfrom
fix/edge-preview-proxy-metrics-release

Conversation

Copy link
Copy Markdown
Contributor

Adds the changeset that #14704 omitted, so that edge-preview-authenticated-proxy actually gets deployed and starts reporting Prometheus metrics again.

What's broken

The Prometheus_Rule_Failed_Checks pint alert has been firing against chat-workers-devprod. pint_problem{owner="chat-workers-devprod"} currently returns 12 series, all for this Worker and none for the other two DevProd Workers:

reporter: promql/series
kind:     recording
filename: /etc/prometheus/recording.d/global_edge_devprod.rules.yaml
name:     global:devprod_edge_preview_authenticated_proxy_error:ratio15m   (and :ratio3h)
problem:  query on nonexistent series: `edge` Prometheus server at
          https://edge.prometheus-access.cfdata.org didn't have any series for the
          `colo:devprod_edge_preview_authenticated_proxy_request:increase15m`
          metric in the last 1w.

The denominator of the SLI doesn't exist because the Worker isn't pushing any counters.

Why

tools/deployments/deploy-non-npm-packages.ts only deploys packages present in PUBLISHED_PACKAGES, i.e. packages that changesets actually version-bumped. All three Workers have wrangler/@cloudflare/workers-utils as devDependencies, so changesets never bumps them automatically. No changeset means no version bump, which means no deploy — the WShim fix was merged over a month ago but has never reached production.

The change

A changeset only, no code changes. changeset status confirms @cloudflare/edge-preview-authenticated-proxy is now queued for a patch bump, which will put it into PUBLISHED_PACKAGES and trigger wrangler deploy on the next release.

Verifying after release

count(edge_preview_authenticated_proxy_devprod_edge_preview_authenticated_proxy_request_total) should become non-empty and pint_problem{owner="chat-workers-devprod"} should go empty. format-errors took ~2 days to reappear after its deploy. The alert has for: 4h, so expect it to resolve a few hours after the series returns.

One thing to watch: #14704 also added secrets.required to this Worker's wrangler.jsonc. Those become inherit bindings and the API hard-fails the deploy if any of PROMETHEUS_TOKEN, SENTRY_ACCESS_CLIENT_SECRET or SENTRY_ACCESS_CLIENT_ID is unset. All three were used by the pre-#14704 code so they should already exist, but that's the first thing to check if the deploy step fails.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: this PR contains no code changes. It only adds the changeset that [devprod] Migrate metrics to WShim internal binding #14704 omitted, so the already-merged and tested code finally gets released.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this is an internal Cloudflare Worker with no public API surface.

A picture of a cute animal (not mandatory, but encouraged)

Note

This is a contribution from an AI agent: OpenCode, claude-opus-5.

changeset-bot Bot commented Aug 16, 2026
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5875e2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/edge-preview-authenticated-proxy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-project-automation Bot moved this to Untriaged in workers-sdk Aug 16, 2026
workers-devprod requested review from a team and jamesopstad and removed request for a team August 16, 2026 16:24

workers-devprod commented Aug 16, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

✅ All changesets look good

This comment was marked as resolved.

ask-bonk Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

The changeset follows the correct format:

  • Valid package name @cloudflare/edge-preview-authenticated-proxy
  • patch type — appropriate for this fix (releasing a previously-merged code change)
  • Single imperative title sentence, then a body paragraph explaining the why
  • No h1/h2/h3 headers
  • No config examples requiring wrangler.json format

The changeset content is accurate to the PR description, the package name is valid, and the version bump type is correct. This is a changeset-only PR with no code changes and no logic to review.

LGTM

github run

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
petebacondarwin enabled auto-merge (squash) August 16, 2026 16:28

workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Codeowners reviews satisfied

petebacondarwin merged commit 32782e4 into main Aug 16, 2026
57 checks passed
github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 16, 2026
petebacondarwin deleted the fix/edge-preview-proxy-metrics-release branch August 16, 2026 16:28
github-project-automation Bot moved this from Approved to Done in workers-sdk Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL