Fix: wrong key used to access log-cache root endpoint. Fix cloudfoundry#1251 - #1252
Merged
Kehrlann merged 3 commits intoJun 13, 2025
Merged
Kehrlann merged 3 commits into
Kehrlann merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
...lient-reactor/src/main/java/org/cloudfoundry/reactor/logcache/v1/_ReactorLogCacheClient.java
Outdated
| import org.cloudfoundry.logcache.v1.ReadRequest; | ||
| import org.cloudfoundry.logcache.v1.ReadResponse; | ||
| import org.cloudfoundry.reactor.ConnectionContext; | ||
| import org.cloudfoundry.reactor.RootProvider; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
unused import, please remove
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
please rebase on main |
Sorry, something went wrong.
Lokowandtg
force-pushed
the
fixLogCacheRootAccess
branch
from
e35de47 to
b2435fa
Compare
February 20, 2025 18:16
Copy link
Copy Markdown
|
|
Sorry, something went wrong.
Lokowandtg
force-pushed
the
fixLogCacheRootAccess
branch
from
b2435fa to
6ec4124
Compare
February 24, 2025 17:06
Kehrlann
requested changes
May 28, 2025
Comment thread
...nt-reactor/src/test/java/org/cloudfoundry/reactor/logcache/v1/ReactorLogCacheClientTest.java
Outdated
Kehrlann
reviewed
May 28, 2025
Comment thread
...nt-reactor/src/test/java/org/cloudfoundry/reactor/logcache/v1/ReactorLogCacheClientTest.java
Outdated
Lokowandtg
force-pushed
the
fixLogCacheRootAccess
branch
from
6ec4124 to
10b8c0d
Compare
June 11, 2025 20:29
Kehrlann
self-requested a review
June 13, 2025 08:05
Kehrlann
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1251.
The key to access the log-cache URL hay a typo.
Add one testcase to the normal access with the key.
Add one testcase for the fallback if the root endpoint does not provide the value. This test shows that the letters "api" in the remaining URL are also replaced, leading to invalid results.