| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
please rebase on main |
Sorry, something went wrong.
|
I could assert this PR fixes the 32 Junit errors on Java 17 AND Java 21. Thank you! 🙏 @Lokowandtg can you please in your branch your update the CI to :
matrix:
java: [ 8, 11 ]
and then replace - if: ${{ matrix.java != 8 }}
with - if: ${{ matrix.java == 11 }}
Thanks again! |
Sorry, something went wrong.
|
@Lokowandtg thanks for your contribution! I'm picking this back up. |
Sorry, something went wrong.
|
@Kehrlann thanks for having a look! |
Sorry, something went wrong.
|
I've tried locally, and as Anthony pointed out, it works fine 🎉 Spotless should work on JDK11+ , so I'd recommend keeping the original: - if: ${{ matrix.java != 8 }}And then I'll merge this. |
Sorry, something went wrong.
in cloudfoundry-operations there are 32 JUnit errors when jdk 11 or jdk17 are used. Those are fixed with this change. So far not tested with later jdks.
There was a problem hiding this comment.
Looks good, thanks for your contribution!
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
In cloudfoundry-operations there are 32 JUnit errors when jdk 11 or jdk 17 are used. Those are fixed with this change. So far not tested with later jdks.
fixes #1255