FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix docker, disk_quota and health+readiness check type serialization by schulzh · Pull Request #1261 · cloudfoundry/cf-java-client · GitHub

  1. cloudfoundry
  2. cf-java-client

Repository navigation

fix docker, disk_quota and health+readiness check type serialization - #1261

Merged
Kehrlann merged 4 commits into
cloudfoundry:mainfrom
schulzh:fix-manifest
Jun 10, 2025
ConversationCommits (4)ChecksFiles changed
Merged

fix docker, disk_quota and health+readiness check type serialization#1261
Kehrlann merged 4 commits into
cloudfoundry:mainfrom
schulzh:fix-manifest

Conversation

schulzh commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

This fixes two issues we've encountered with the manifest serialization.

The first is that docker was not serialized as a deep structure, but as a string (java object representation), which breaks the yaml. The second issue is that the disk quota was not serialized with the correct field name.

anthonydahanne commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

Hello @schulzh , thank you for your contribution!
Could you please add a unit test just to assert this does not change inadvertently?

schulzh commented Feb 16, 2025

Copy link
Copy Markdown
Contributor Author

Hi @anthonydahanne , I've added a unit test, could you take a look again?

schulzh changed the title fix docker serialization and disk_quota fix docker, disk_quota and readiness check type serialization Feb 21, 2025
schulzh changed the title fix docker, disk_quota and readiness check type serialization fix docker, disk_quota and health+readiness check type serialization Feb 21, 2025

schulzh commented Feb 21, 2025

Copy link
Copy Markdown
Contributor Author

Hi @anthonydahanne , I've added two more serialization fixes to the PR.

Kehrlann self-requested a review April 30, 2025 07:46
Lokowandtg reviewed May 20, 2025
View reviewed changes

Lokowandtg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm
(but not tested)

Kehrlann self-assigned this May 28, 2025
Kehrlann added this to the 6.0.0 release milestone May 28, 2025

Kehrlann commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Hi @schulzh ! Thanks for your contribution.

Would you mind rebasing on main before we can merge this please?

schulzh commented Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

Hi @Kehrlann , i've updated the branch.

Kehrlann approved these changes Jun 10, 2025
View reviewed changes

Kehrlann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good!
I was hoping for a rebase rather than a merge, but that's OK.

Kehrlann merged commit e18f771 into cloudfoundry:main Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Lokowandtg Lokowandtg left review comments
Kehrlann Kehrlann approved these changes

Assignees

Kehrlann

Labels

None yet

Projects

None yet

Milestone

6.0.0 release

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL