Implement the Space Quota version 3 API - #1320
Merged
Kehrlann merged 5 commits intoDec 3, 2025
Merged
Kehrlann merged 5 commits into
Kehrlann merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Kehrlann
requested changes
Dec 2, 2025
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for your contribution! Most important points are the naming and the extra test.
The other comment is something to consider. Curious to hear what you think.
Edit: integration tests pass 👍
Sorry, something went wrong.
Comment thread
...ent/src/main/java/org/cloudfoundry/client/v3/spacequotadefinitions/SpaceQuotaDefinition.java
Outdated
Comment thread
integration-test/src/test/java/org/cloudfoundry/client/v3/SpaceQuotaDefinitionsTest.java
Outdated
added 4 commits
December 2, 2025 11:50
Kehrlann
self-requested a review
December 3, 2025 13:47
Kehrlann
approved these changes
Dec 3, 2025
Kehrlann
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thank you for your contribution.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides an implementation of all API for the Space Quota except for Apply / Remove an space quota to an Space
I plan to implement that Apply API in a future PR. The Space Quota follows the pattern that Organization Quota version 3 API interface and implementation follow
The PR is intended to replace #1305 being based off the latest main with all commits squashed to a single commit