FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix UAA Authorizations accept headers by Lokowandtg · Pull Request #1379 · cloudfoundry/cf-java-client · GitHub

  1. cloudfoundry
  2. cf-java-client

Repository navigation

Fix UAA Authorizations accept headers - #1379

Merged
Kehrlann merged 1 commit into
cloudfoundry:5.x.xfrom
Lokowandtg:5.x.x.Authorizations
Oct 2, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Fix UAA Authorizations accept headers#1379
Kehrlann merged 1 commit into
cloudfoundry:5.x.xfrom
Lokowandtg:5.x.x.Authorizations

Conversation

Lokowandtg commented Sep 30, 2026 •
edited by Kehrlann
Loading

Copy link
Copy Markdown
Contributor

Now in the correct branch

Fixes #1374

Lokowandtg requested a review from Kehrlann September 30, 2026 15:35
Kehrlann reviewed Oct 1, 2026
View reviewed changes

Kehrlann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Which tests are failing exactly?
Which UAA version?

Comment thread ...reactor/src/main/java/org/cloudfoundry/reactor/uaa/authorizations/ReactorAuthorizations.java
GetOpenIdProviderConfigurationResponse.class,
builder -> builder.pathSegment(".well-known", "openid-configuration"))
builder -> builder.pathSegment(".well-known", "openid-configuration"),
ReactorAuthorizations::removeAuthorization)

Kehrlann Oct 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why remove authorization here?

Lokowandtg Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The documentation here: https://docs.cloudfoundry.org/api/uaa/version/79.1.0/index.html#openid-provider-configuration-request does not require an authorization for this request.

Comment thread ...reactor/src/main/java/org/cloudfoundry/reactor/uaa/authorizations/ReactorAuthorizations.java
HttpHeaderNames.ACCEPT,
HttpHeaderValues.APPLICATION_X_WWW_FORM_URLENCODED);
},
ReactorAuthorizations::removeAuthorization)

Kehrlann Oct 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

why remove authorization here?

Lokowandtg Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Same here, documentation states that is works without authorization.

Kehrlann reviewed Oct 1, 2026
View reviewed changes

Kehrlann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Prefer outbound.set(, ) to remove + add

Comment thread ...reactor/src/main/java/org/cloudfoundry/reactor/uaa/authorizations/ReactorAuthorizations.java
Comment on lines +104 to +109
outbound -> {
outbound.remove(HttpHeaderNames.ACCEPT);
outbound.add(
HttpHeaderNames.ACCEPT,
HttpHeaderValues.APPLICATION_X_WWW_FORM_URLENCODED);
},

Kehrlann Oct 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
outbound -> {
outbound.remove(HttpHeaderNames.ACCEPT);
outbound.add(
HttpHeaderNames.ACCEPT,
HttpHeaderValues.APPLICATION_X_WWW_FORM_URLENCODED);
},
outbound ->
outbound.set(
HttpHeaderNames.ACCEPT,
HttpHeaderValues.APPLICATION_X_WWW_FORM_URLENCODED),

Lokowandtg Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good point. Will do.

Kehrlann mentioned this pull request Oct 1, 2026
Closed

Lokowandtg commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Which tests are failing exactly?
Failing:
authorizeByAuthorizationCodeGrantBrowser
authorizeByImplicitGrantBrowser
authorizeByOpenIdWithImplicitGrant
authorizeByOpenIdWithIdToken
authorizeByAuthorizationCodeGrantHybrid
authorizeByOpenIdWithAuthorizationCodeGrant

Success:
openIdProviderConfiguration
authorizeByAuthorizationCodeGrantApi

Which UAA version?
Tested with UAA version cloudfoundry/uaa-release 79.5.1-1, the problem exists for at least a year.

Kehrlann changed the title fix #1374, AuthorizationsTest 6 out of 8 are failing Fix UAA Authorizations accept headers Oct 2, 2026
Kehrlann merged commit e4fd964 into cloudfoundry:5.x.x Oct 2, 2026
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Kehrlann Kehrlann left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL