FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: Migrate hackernews to go.uber.org/mock by erezrokah · Pull Request #23258 · cloudquery/cloudquery · GitHub

/ cloudquery Public

chore: Migrate hackernews to go.uber.org/mock - #23258

Merged
kodiakhq[bot] merged 1 commit into
mainfrom
chore/uber-mock-hackernews
Aug 20, 2026
ConversationCommits (1)ChecksFiles changed
Merged

chore: Migrate hackernews to go.uber.org/mock#23258
kodiakhq[bot] merged 1 commit into
mainfrom
chore/uber-mock-hackernews

Conversation

erezrokah commented Aug 18, 2026

Copy link
Copy Markdown
Member

Replace the archived github.com/golang/mock with go.uber.org/mock v0.6.0 in the hackernews plugin and regenerate its mocks.

erezrokah marked this pull request as ready for review August 18, 2026 15:44
erezrokah requested a review from a team as a code owner August 18, 2026 15:44
erezrokah requested review from dcelasun and disq and removed request for dcelasun August 18, 2026 15:44
erezrokah added the automerge Automatically merge once required checks pass label Aug 18, 2026

greptile-apps Bot commented Aug 18, 2026

Copy link
Copy Markdown

Greptile Summary

This PR migrates the Hacker News plugin from the archived github.com/golang/mock module to go.uber.org/mock v0.6.0.

  • Updates the module and pinned mock-generation tool.
  • Regenerates both mock implementations with the new generator.
  • Updates helper and test imports to use the new gomock package.
  • Refreshes dependency checksums and generated license documentation.

Confidence Score: 5/5

The PR appears safe to merge, with the mock dependency, generated implementations, helper code, and test callers migrated consistently.

No changed-code-triggered failure remains: all relevant Hacker News imports use the replacement package, generated mock signatures match their callers, and the flagged vulnerable transitive dependency version is unchanged from the base branch.

Important Files Changed

Filename Overview
plugins/source/hackernews/go.mod Replaces the old GoMock dependency with go.uber.org/mock v0.6.0 while preserving the rest of the selected module versions.
plugins/source/hackernews/client/mocks/backend.go Regenerates the BackendClient mock using the new GoMock package and generator format.
plugins/source/hackernews/client/mocks/hackernews.go Regenerates the HackernewsClient mock using the new GoMock package without changing the mocked interface behavior.
plugins/source/hackernews/client/testing.go Moves shared test setup to the same go.uber.org/mock controller type used by the regenerated mocks.
plugins/source/hackernews/tools/tool.go Pins the replacement mockgen tool so future mock generation remains consistent.
plugins/source/hackernews/resources/plugin/connection_tester_test.go Updates the test to use the controller package expected by the regenerated mocks.
plugins/source/hackernews/resources/services/items/items_fetch_test.go Updates item-fetch tests to use the replacement GoMock controller package.

Reviews (1): Last reviewed commit: "chore: Migrate hackernews to go.uber.org..." | Re-trigger Greptile

kodiakhq Bot merged commit 23099cd into main Aug 20, 2026
12 checks passed
kodiakhq Bot deleted the chore/uber-mock-hackernews branch August 20, 2026 08:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

disq disq approved these changes

Assignees

No one assigned

Labels

area/plugin/source/hackernews automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL