FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added license details to dataset object. This is required for migrati… by ddey2 · Pull Request #455 · clowder-framework/clowder · GitHub

/ clowder Public

Added license details to dataset object. This is required for migrati… - #455

Open
ddey2 wants to merge 3 commits into
developfrom
1191-add-license-to-dataset-object
ConversationCommits (3)ChecksFiles changed
Open

Added license details to dataset object. This is required for migrati…#455
ddey2 wants to merge 3 commits into
developfrom
1191-add-license-to-dataset-object

Conversation

ddey2 commented Aug 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

…ng licenses to v2.

Description

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

ddey2 mentioned this pull request Aug 30, 2024
Merged
longshuicy reviewed Aug 30, 2024
View reviewed changes

longshuicy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Without testing, the code looks good.
Could you add an entry in the changelog?

ddey2 commented Aug 30, 2024

Copy link
Copy Markdown
Member Author

Without testing, the code looks good. Could you add an entry in the changelog?

added

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

longshuicy longshuicy left review comments
lmarini Awaiting requested review from lmarini
tcnichol Awaiting requested review from tcnichol

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL