FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update Vietnamese translations by kuroni · Pull Request #1052 · cms-dev/cms · GitHub

/ cms Public

Update Vietnamese translations - #1052

Merged
lw merged 1 commit into
cms-dev:masterfrom
kuroni:master
Oct 23, 2018
ConversationCommits (1)ChecksFiles changed
Merged

Update Vietnamese translations#1052
lw merged 1 commit into
cms-dev:masterfrom
kuroni:master

Conversation

kuroni commented Oct 23, 2018 •
edited by stefano-maggiolo
Loading

Copy link
Copy Markdown
Contributor

This change is 

codecov Bot commented Oct 23, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1052 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
+ Coverage   62.04%   62.07%   +0.02%     
==========================================
  Files         228      228              
  Lines       16434    16434              
==========================================
+ Hits        10197    10201       +4     
+ Misses       6237     6233       -4
Flag Coverage Δ
#functionaltests 46.12% <ø> (-0.03%) ⬇️
#unittests 43.16% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
cms/grading/Job.py 86.25% <0%> (-4.27%) ⬇️
cms/db/filecacher.py 76.72% <0%> (-1.32%) ⬇️
cms/db/util.py 50% <0%> (-0.76%) ⬇️
cms/io/priorityqueue.py 92.7% <0%> (-0.73%) ⬇️
cms/server/admin/handlers/base.py 68.13% <0%> (ø) ⬆️
cms/service/EvaluationService.py 67.02% <0%> (+0.26%) ⬆️
cms/grading/Sandbox.py 68.59% <0%> (+0.36%) ⬆️
cms/service/ProxyService.py 57.97% <0%> (+0.53%) ⬆️
cms/io/service.py 69.51% <0%> (+0.6%) ⬆️
cms/io/rpc.py 92.15% <0%> (+0.68%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9b8c4...47fe9e3. Read the comment docs.

kuroni closed this Oct 23, 2018
kuroni reopened this Oct 23, 2018
lw merged commit a3a1276 into cms-dev:master Oct 23, 2018

lw commented Oct 23, 2018

Copy link
Copy Markdown
Member

Merged, both in master and in v1.4. Thanks!

kuroni commented Oct 23, 2018

Copy link
Copy Markdown
Contributor Author

I just realized I messed up with the spacing in a few multi-line translations :( Can I revert the merge and create a new pull request? I am really sorry for the inconvenience :(

wil93 commented Oct 23, 2018

Copy link
Copy Markdown
Member

Just create a new pull-request based on the current master, no need to revert 😄

lw mentioned this pull request Oct 23, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL