FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

RWS: add -y switch to allow unattended data drop by tuankiet65 · Pull Request #1057 · cms-dev/cms · GitHub

/ cms Public

RWS: add -y switch to allow unattended data drop - #1057

Merged
lw merged 2 commits into
cms-dev:masterfrom
tuankiet65:master
Nov 1, 2018
ConversationCommits (2)ChecksFiles changed
Merged

RWS: add -y switch to allow unattended data drop#1057
lw merged 2 commits into
cms-dev:masterfrom
tuankiet65:master

Conversation

tuankiet65 commented Nov 1, 2018 •
edited by stefano-maggiolo
Loading

Copy link
Copy Markdown
Contributor

If the -y switch is specified then CMS would drop the data directory without asking for confirmation. This is desirable for automation scripts since without the switch, the script would have to pipe yes into the RWS process (yes | cmsRankingWebServer -d). cmsDropDB has this switch so I think RWS should also have one.

This change is 

codecov Bot commented Nov 1, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1057 into master will increase coverage by 0.15%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
+ Coverage   61.88%   62.04%   +0.15%     
==========================================
  Files         228      228              
  Lines       16434    16437       +3     
==========================================
+ Hits        10170    10198      +28     
+ Misses       6264     6239      -25
Flag Coverage Δ
#functionaltests 46.13% <25%> (+0.28%) ⬆️
#unittests 43.15% <0%> (-0.04%) ⬇️
Impacted Files Coverage Δ
cmsranking/RankingWebServer.py 42.61% <25%> (-0.08%) ⬇️
cms/io/priorityqueue.py 92.7% <0%> (-2.19%) ⬇️
cms/db/base.py 82.97% <0%> (-1.07%) ⬇️
cms/service/EvaluationService.py 66.75% <0%> (-0.8%) ⬇️
cms/db/util.py 50% <0%> (-0.76%) ⬇️
cms/io/rpc.py 91.12% <0%> (ø) ⬆️
cms/io/service.py 69.51% <0%> (+0.6%) ⬆️
cms/grading/Sandbox.py 68.59% <0%> (+0.72%) ⬆️
cms/server/admin/handlers/dataset.py 25.69% <0%> (+0.92%) ⬆️
cms/db/filecacher.py 78.03% <0%> (+0.98%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3120563...34c9021. Read the comment docs.

lw approved these changes Nov 1, 2018
View reviewed changes

lw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

lw merged commit 1b69c15 into cms-dev:master Nov 1, 2018

lw commented Nov 1, 2018

Copy link
Copy Markdown
Member

Thanks, merged into master!

tuankiet65 commented Nov 1, 2018

Copy link
Copy Markdown
Contributor Author

Wew, that was quick, thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lw lw approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL