Fix whitespace in consecutive {% trans %} blocks - #1063
Merged
lw merged 1 commit intoNov 4, 2018
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Due to active Jinja whitespace handling, whitespace was removed between
consecutive {% trans %} blocks, resulting in translated sentences being
glued together. Fix this by disabling the lstrip_blocks behaviour in
relevant places.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1063 +/- ##
==========================================
+ Coverage 61.97% 62.08% +0.11%
==========================================
Files 228 228
Lines 16436 16436
==========================================
+ Hits 10186 10205 +19
+ Misses 6250 6231 -19
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Very good catch, I had never noticed, thanks! Pushed to master and v1.4. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to active Jinja whitespace handling, whitespace was removed between consecutive {% trans %} blocks, resulting in translated sentences being glued together. Fix this by disabling the lstrip_blocks behaviour in relevant places.
This change is