FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clearer unofficial submissions in CWS by stefano-maggiolo · Pull Request #1091 · cms-dev/cms · GitHub

/ cms Public

Clearer unofficial submissions in CWS - #1091

Merged
stefano-maggiolo merged 2 commits into
cms-dev:masterfrom
stefano-maggiolo:twotables
Jan 7, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Clearer unofficial submissions in CWS#1091
stefano-maggiolo merged 2 commits into
cms-dev:masterfrom
stefano-maggiolo:twotables

Conversation

stefano-maggiolo commented Dec 10, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

This change is 

stefano-maggiolo commented Dec 10, 2018

Copy link
Copy Markdown
Member Author

With both official and unofficial submissions:

Only with official submissions:

Only with unofficial submissions (I removed the "yet" since this screenshot)

codecov Bot commented Dec 10, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1091 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
+ Coverage    62.2%   62.22%   +0.01%     
==========================================
  Files         229      229              
  Lines       16520    16520              
==========================================
+ Hits        10276    10279       +3     
+ Misses       6244     6241       -3
Flag Coverage Δ
#functionaltests 46.1% <ø> (+0.04%) ⬆️
#unittests 43.29% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
cms/grading/Job.py 82.93% <0%> (-6.17%) ⬇️
cms/io/priorityqueue.py 92.7% <0%> (-2.19%) ⬇️
cms/db/util.py 52.59% <0%> (-0.75%) ⬇️
cms/service/esoperations.py 80.14% <0%> (-0.71%) ⬇️
cms/io/rpc.py 91.8% <0%> (-0.69%) ⬇️
cms/io/service.py 68.9% <0%> (-0.61%) ⬇️
cms/service/EvaluationService.py 67.55% <0%> (-0.27%) ⬇️
cms/server/admin/handlers/dataset.py 25.69% <0%> (+0.3%) ⬆️
cms/grading/Sandbox.py 68.59% <0%> (+0.36%) ⬆️
cms/db/filecacher.py 78.68% <0%> (+0.98%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9335527...8aa745b. Read the comment docs.

andreyv commented Dec 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Is the "Official" column in the table still needed after the redesign?

EDIT: Sorry, I was looking at the screenshots and not the code.

stefano-maggiolo commented Dec 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

No, I think I removed it, didn't I?

Edit: oh, I see, in the screenshot - yeah, I took them before removing the column and was too lazy to take them again

Btw, if you want to do full review, feel free - @lerks seems a bit overworked :)

lw approved these changes Dec 13, 2018
View reviewed changes

lw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You changed the message (by removing "yet") but didn't regenerate cms.pot. Up to you whether to do it now or just before the next release.

Reviewed 2 of 2 files at r1, 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

Move CWS's submission table to its own template file
ad4339d
Show official and unofficial submissions in two different tables in CWS
8aa745b 
Previously, we assumed that unofficial submissions only appeared
during the analysis phase, and only handled clearly that case (in
analysis phase, we added a column "official").

But an admin can also change the official status at any time for any
reason, and this would create a lot of confusion, especially when not
in analysis phase when we won't even have the official column.

With this change, we remove the official column, and we render one or two tables:

- if there are 0 unofficial submissions, we only render the official
  submissions table (possibly empty) with no title.

- if there are 1 or more unofficial submissions, we render both tables
  (the official one possibly empty), with titles.

stefano-maggiolo commented Jan 7, 2019

Copy link
Copy Markdown
Member Author

Per #1096, not regenerating the pot.

stefano-maggiolo merged commit 8aa745b into cms-dev:master Jan 7, 2019
stefano-maggiolo deleted the twotables branch January 7, 2019 22:22
wil93 mentioned this pull request Nov 27, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lw lw approved these changes

Assignees

lw

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL