FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix ProxyService team.code encoding for user by PPakalns · Pull Request #1117 · cms-dev/cms · GitHub

/ cms Public

Fix ProxyService team.code encoding for user - #1117

Merged
andreyv merged 1 commit into
cms-dev:masterfrom
PPakalns:proxyservice-team-encoding-for-user
Nov 17, 2021
Merged

Fix ProxyService team.code encoding for user#1117
andreyv merged 1 commit into
cms-dev:masterfrom
PPakalns:proxyservice-team-encoding-for-user

Conversation

PPakalns commented Feb 24, 2019
edited by stefano-maggiolo
Loading

Copy link
Copy Markdown
Contributor

Fix inconsistent team.code encoding in ProxyService.

It breaks if team.code has _ or any other non digit, non letter character.


This change is 

codecov Bot commented Feb 24, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1117 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   62.17%   61.89%   -0.28%     
==========================================
  Files         230      230              
  Lines       16591    16592       +1     
==========================================
- Hits        10315    10270      -45     
- Misses       6276     6322      +46
Flag Coverage Δ
#functionaltests 45.71% <ø> (-0.27%) ⬇️
#unittests 43.26% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cms/service/ProxyService.py 59.04% <ø> (-2.13%) ⬇️
cms/io/PsycoGevent.py 57.14% <0%> (-11.43%) ⬇️
cms/grading/Job.py 80.09% <0%> (-9.48%) ⬇️
cms/db/base.py 85.1% <0%> (-5.32%) ⬇️
cms/service/esoperations.py 78.01% <0%> (-4.97%) ⬇️
cms/server/admin/handlers/task.py 39.84% <0%> (-1.18%) ⬇️
cms/service/EvaluationService.py 67.28% <0%> (-1.07%) ⬇️
cms/db/filecacher.py 77.04% <0%> (-0.99%) ⬇️
cms/server/contest/handlers/taskusertest.py 43.03% <0%> (-0.61%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c7e91d...3293706. Read the comment docs.

cms-dev deleted a comment Feb 28, 2019
andreyv force-pushed the proxyservice-team-encoding-for-user branch from 3293706 to 395ad6b Compare November 17, 2021 14:47

andreyv commented Nov 17, 2021

Copy link
Copy Markdown
Member

Thanks, it works 🙂 I applied slight style changes.

andreyv merged commit d77b3bd into cms-dev:master Nov 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL