Replace most subprocess.call() invocations with check_call() - #1128
Conversation
Sorry, something went wrong.
|
One of the newly added checks fails: ERROR [Worker,3 4 Worker::execute_job_group] Worker failed: Command '['isolate', '--cg', '--box-id=40', '--dir=/tmp=/tmp/cms-compile-50t1z18h/home:rw', '--run', '--', '/bin/chmod', '777', '-R', '/tmp']' returned non-zero exit status 1.. |
Sorry, something went wrong.
|
The output from isolate is something like /bin/chmod: changing permissions of '/tmp': Operation not permitted /bin/chmod: changing permissions of '/tmp/checker': Operation not permitted /bin/chmod: changing permissions of '/tmp/user_output.txt': Operation not permitted /bin/chmod: changing permissions of '/tmp/input.txt': Operation not permitted /bin/chmod: changing permissions of '/tmp/correct_output.txt': Operation not permitted Exited with error status 1 Looking at the home directory, the mentioned files are owned by the CMS user instead of the sandbox user. The chmod command runs as the sandbox user. Looks like this behavior is intended. A comment can be added that the exit code should be ignored. |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #1128 +/- ##
==========================================
- Coverage 63.52% 61.98% -1.55%
==========================================
Files 232 230 -2
Lines 17028 16611 -417
==========================================
- Hits 10817 10296 -521
- Misses 6211 6315 +104
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sorry, something went wrong.
This ensures proper error handling. In some places manual error reporting is also replaced with Python chained exceptions. Manual error handling is left in loaders because multiple other places also return None instead of raising an exception. It could be refactored separately if needed.
This ensures proper error handling. In some places manual error reporting is also replaced with Python chained exceptions.
Manual error handling is left in loaders because multiple other places also return None instead of raising an exception. It can be refactored too if needed.
This change is