| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
+ Coverage 63.43% 63.90% +0.47%
==========================================
Files 232 233 +1
Lines 17050 17106 +56
==========================================
+ Hits 10815 10932 +117
+ Misses 6235 6174 -61
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sorry, something went wrong.
There was a problem hiding this comment.
What's the current status of TwoSteps? Are we letting it rot away?
Sorry, something went wrong.
Language executable file names can now have extensions. This allows to simplify language compilation commands in multiple cases. Task type plugins and tests are updated accordingly.
Thanks, I updated it as well (somewhat). Even in master, as I can see, TwoSteps won't work with Python etc., because it doesn't call get_evaluation_commands(), but rather just runs ./executable. But at least now it is not broken more than it is in master. |
Sorry, something went wrong.
|
I had one more comment request then feel free to push to master. Thank you! |
Sorry, something went wrong.
|
Thanks! I'll push the changes soon. |
Sorry, something went wrong.
|
Merged. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This property allows to simplify language compilation commands in multiple cases. The compilation commands presented to the user are also easier to understand.
The initial motivation for this change was to be able to use python3 -m zipapp instead of manual archiving for the Python 3 language. Currently this doesn't work, however, because from PEP 441 there must be a __main__.py file in the archive, and zipapp enforces this. But these changes are still useful for multiple other languages.
A couple of notes:
cms/cms/grading/tasktypes/Batch.py
Lines 256 to 257 in d4c9e92
I think it could query the task object instead. Perhaps a new issue can be opened.
cms/cms/grading/steps/utils.py
Lines 88 to 89 in d4c9e92
because stats is None. On the other hand, it is not clear how this can be reconciled with the case of multiple source files.
This change is