| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
==========================================
- Coverage 63.63% 63.58% -0.05%
==========================================
Files 232 232
Lines 17044 17044
==========================================
- Hits 10846 10838 -8
- Misses 6198 6206 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sorry, something went wrong.
|
Thanks for the fix :) From the code, it looks like the datetime and time classes are intended for styling the first column. See cws_style.css and similar code in submission.html. In particular, there seems to be another bug here: the col.time selector appears twice and overrides its previous definition. What do you think about keeping datetime/time for the first column and re-classing the third column, in both colgroup and tbody, to something like execution_time? This would fix both problems and keep consistency with the submissions table. |
Sorry, something went wrong.
It's been a while, I have made the changes as you suggested and rebased it on the current master branch. Thanks for the review too! Would you mind reviewing it again? |
Sorry, something went wrong.
|
Thanks! The fix looks good now. I adjusted the key in JSON response from time to execution_time as well. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR fixes issue #1159
This change is