Codecov Report

Merging #1165 (f41a5d8) into master (91a32fc) will increase coverage by 0.13%.
The diff coverage is 90.32%.

@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
+ Coverage   63.68%   63.82%   +0.13%     
==========================================
  Files         233      233              
  Lines       17113    17131      +18     
==========================================
+ Hits        10899    10934      +35     
+ Misses       6214     6197      -17     

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a32fc...f41a5d8. Read the comment docs.

Thanks.

Observe that this feature is conceptually very similar to a contest loader: there is some task data and one wants to import it. Just for clarification, do you use it for a similar purpose, e.g., prepare a contest on a staging server and import it on a testing/production server?

Yes, this is for the purpose you mentioned. The 'staging' server as well as the testing/production server are both CMS.

At the moment, this is done by exporting the contest (using cmsDumpExporter) from the staging CMS instance and then re-importing them into the production instance using cmsDumpImporter.

Would you recommend looking into implementing a ContestLoader that reads from a cms dump exporter format?

Thanks for the explanation.

I think the "recommended" and more robust solution would be to prepare the contest using one of the loader formats in the first place, and import it both on the staging and production servers.

But I suppose a complementary solution like this one can be added as well, if it is useful. In this case, you should also add the same option to DumpImporter.py to keep it synchronized with DumpExporter.py.

@andreyv Requested changes have been made, do review when you have the time.

Thanks once again :)

Thanks, it looks good now.

I see that you added tests and also fixed a bug that could cause DumpImporter to import everything instead of skipping items as requested — nice!

I added some minor changes in f41a5d8:

• In DumpExporter, simplify the user-related class list and only check classes that can be reached from root (from Contest and Task classes). The other previously listed classes, including User, should not appear there.
• In DumpImporter, also skip Announcement. Otherwise it could indirectly import Admins as well when importing a full dump with -X.
• Whitespace and indentation fixes.

I'll merge this MR in a few days if you have no further comments.

Merged!