Let all services share the file cache directory - #1183
Merged
andreyv merged 4 commits intoJun 3, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1183 +/- ##
==========================================
- Coverage 63.48% 63.47% -0.01%
==========================================
Files 232 232
Lines 17046 17050 +4
==========================================
+ Hits 10821 10823 +2
- Misses 6225 6227 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Even if someone keeps deleting all cached files, a file can always be used after downloading it just once. (Previously, this could have become an infinite loop if the file gets deleted sufficiently quickly every time.)
andreyv
reviewed
Jun 2, 2021
andreyv
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks! Great idea about making _load() private.
The only unclear part in the changes is about FileCacher.save(), see the individual comments.
Sorry, something went wrong.
Comment thread
cms/db/filecacher.py
Outdated
Comment thread
cms/db/filecacher.py
Outdated
Comment thread
cms/db/filecacher.py
Outdated
Comment thread
cms/db/filecacher.py
Copy link
Copy Markdown
Member
|
Merged. Thanks! I'm not sure there is a need for an option to disable this behavior. I think, for now it is fine as is. |
Sorry, something went wrong.
ranaldmiao
pushed a commit
to ranaldmiao/cms
that referenced
this pull request
Jun 21, 2021
* Let all services share the file cache directory * Disallow destroying/purging a shared cache * After downloading a file, open the temporary file before moving Even if someone keeps deleting all cached files, a file can always be used after downloading it just once. (Previously, this could have become an infinite loop if the file gets deleted sufficiently quickly every time.) * Small changes
RezwanArefin01
pushed a commit
to RezwanArefin01/cms
that referenced
this pull request
Dec 27, 2021
* Let all services share the file cache directory * Disallow destroying/purging a shared cache * After downloading a file, open the temporary file before moving Even if someone keeps deleting all cached files, a file can always be used after downloading it just once. (Previously, this could have become an infinite loop if the file gets deleted sufficiently quickly every time.) * Small changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement approach 2 from #1182.
Precaching is not re-enabled in this pull-request.
Services automatically create the shared cache directory if it doesn't exist yet, leading to potential race conditions (#1182 (comment)). The shared cache directory is also created by prerequisites.py install. (In fact, the same holds for config.temp_dir and config.cache_dir, which are also automatically created if they don't exist.) An alternative would be to fail and ask the admin to re-run prerequisites.py install.
In the original issue #154, Giovanni suggested an option to switch back to private caches. I could add an option to cms.conf if this is still desirable.