Update to jQuery 3.6.0 - #1188
Merged
andreyv merged 2 commits intoAug 8, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This covers the following GitHub security advisories: - GHSA-gxr4-xjj5-5px2 - GHSA-jpcq-cgw6-v4j6 - CVE-2019-11358 - CVE-2015-9251 The jQuery Migrate library is also added to maintain compatibility with the current Bootstrap version (2.0.4). Without the compatibility library, the following error occurs when dismissing an alert: Uncaught Error: Syntax error, unrecognized expression: # jQuery (7) close http://localhost:8888/static/js/bootstrap.js:7 jQuery (8) <anonymous> http://localhost:8888/static/js/bootstrap.js:7 jQuery (13) jquery-3.6.0.min.js:2:13639
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1188 +/- ##
==========================================
- Coverage 64.03% 63.73% -0.30%
==========================================
Files 233 233
Lines 17106 17106
==========================================
- Hits 10953 10903 -50
- Misses 6153 6203 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks a bunch, this was long overdue! Good on finding the way to ease the migrate path. |
Sorry, something went wrong.
stefano-maggiolo
approved these changes
Aug 6, 2021
Copy link
Copy Markdown
Member
Author
|
Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update covers the following GitHub security advisories:
After the update dismissing Bootstrap alerts (alert class), shown after submitting a file, on a notification etc., was failing with Syntax error, unrecognized expression: #. This is fixed by adding jquery/jquery-migrate (official project) to CWS pages.
I looked into updating Bootstrap itself some time ago as well. It appears that the currently used distribution was customized using a web generator, which is no longer available, and loading a newer version with default settings produces multiple style differences. Thus updating Bootstrap looks to be a separate task, but until then we can use jquery-migrate.
During testing I also found 13abdd7, which is not related to the update, but is fixed as well.
Otherwise CWS, AWS (including jqplot), RWS seem to work fine with the new jQuery version.