Upgrade gevent and greenlet - #1255
Conversation
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## master #1255 +/- ##
==========================================
- Coverage 69.73% 69.42% -0.31%
==========================================
Files 328 328
Lines 26201 26201
==========================================
- Hits 18271 18191 -80
- Misses 7930 8010 +80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
|
I vaguely remember some reason to keep gevent pinned to 1.5, but tbh I can't remember which. If tests are passing I guess that's fine |
Sorry, something went wrong.
|
It seems I can run the tests successfully even with the latest versions available as of today (gevent 23.9.1 and greenlet 3.0.3), maybe we can upgrade to those versions instead? |
Sorry, something went wrong.
Updating these two to the oldest versions that still successfully build on a Mac M1, mostly just for ease of testing, so I don't have to spin up a linux VM every time. (I still have issues with fp-compiler but that isn't critical).