FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix more bugs in the user groups PR by pxsit · Pull Request #1693 · cms-dev/cms · GitHub

/ cms Public

fix more bugs in the user groups PR - #1693

Open
pxsit wants to merge 3 commits into
cms-dev:mainfrom
pxsit:fix-group
ConversationCommits (3)ChecksFiles changed
Open

fix more bugs in the user groups PR#1693
pxsit wants to merge 3 commits into
cms-dev:mainfrom
pxsit:fix-group

Conversation

pxsit commented May 4, 2026

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings May 4, 2026 07:37
Copilot AI reviewed May 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Fixes auto-registration failures introduced by the addition of mandatory user groups by ensuring newly created participations are assigned to the contest’s default (main) group.

Changes:

  • Assign group=self.contest.main_group when creating a Participation during contest registration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov Bot commented May 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 53.90%. Comparing base (15c547e) to head (551525b).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
cms/server/contest/handlers/main.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1693   +/-   ##
=======================================
  Coverage   53.90%   53.90%           
=======================================
  Files         341      341           
  Lines       27983    27983           
=======================================
+ Hits        15084    15085    +1     
+ Misses      12899    12898    -1
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 53.90% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

veluca93 requested a review from prandla May 4, 2026 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Virv12 Virv12 approved these changes
prandla Awaiting requested review from prandla

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL