FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Pegasus sweep 5/6: remove references to decommissioned pegasus infrastructure by stephenliang · Pull Request #74757 · code-dot-org/code-dot-org · GitHub

Pegasus sweep 5/6: remove references to decommissioned pegasus infrastructure - #74757

Open
stephenliang wants to merge 1 commit into
stephen/pegasus-sweep-4-configfrom
stephen/pegasus-sweep-5-refs
Open

Pegasus sweep 5/6: remove references to decommissioned pegasus infrastructure#74757
stephenliang wants to merge 1 commit into
stephen/pegasus-sweep-4-configfrom
stephen/pegasus-sweep-5-refs

Conversation

stephenliang commented Aug 20, 2026
edited
Loading

Copy link
Copy Markdown
Member

Several files still reference pegasus infrastructure that no longer exists. None of these edits has a deploy surface; this PR is repo hygiene.

  • lib/cdo/honeybadger.rb: drop the retired pegasus project (id 34365) from get_recent_issues. The only caller is bin/dotd, which iterates the project hash generically.
  • lib/cdo/server_tools.rb: delete the ELB deregistration path. A read-only AWS check (2026-07-07, account 475661607190, us-east-1) found zero classic ELBs; all three load balancers it targeted (production-dashboard, production-pegasus, production-redirects) are gone. The internal method, its caller-free public wrapper deregister_frontends, and the call inside deprovision_frontends are deleted, and that method's comment and prompt now describe only what it still does. A finding for later: the whole ServerTools class has zero external references (one of its methods even calls ids.map(:names), which raises, so it can never have run); deleting the rest is follow-up, out of scope here.
  • lib/cdo/sequel.rb: drop a commented-out logging line whose instructions require starting bin/pegasus-server, deleted in part 1.
  • dashboard/lib/certificate_image.rb: drop a stale comment claiming the file needs pegasus_dir; it never uses it. Its real pegasus dependency, require 'cdo/pegasus/string', is live and stays.
  • aws/.gitignore and k8s/docker/code-dot-org.dockerfile.dockerignore (generated from it): drop the .pegasus-built and .pegasus-up-to-date markers. Nothing writes or reads them. The dockerignore lines are hand-edited rather than regenerated so this PR does not pick up unrelated generator drift.

Part 5/6 of the pegasus dead-code sweep. Supersedes draft #74751.

Links

Testing story

Rails boots. ruby -c and rubocop pass on every edited file. Require smoke: cdo/honeybadger, cdo/server_tools, and cdo/sequel each load standalone. Grep gates: deregister_frontends and the marker names appear nowhere outside this diff; 34365 has no other reference.

stephenliang changed the title chore(pegasus): remove references to decommissioned pegasus infrastructure Pegasus sweep 5/6: remove references to decommissioned pegasus infrastructure Aug 20, 2026
stephenliang marked this pull request as ready for review August 20, 2026 16:44
stephenliang requested a review from a team as a code owner August 20, 2026 16:44
stephenliang force-pushed the stephen/pegasus-sweep-5-refs branch from 4b7ef0e to cd15d6c Compare August 20, 2026 21:01
stephenliang force-pushed the stephen/pegasus-sweep-5-refs branch from cd15d6c to 698e849 Compare August 21, 2026 16:29
…cture

Remove repository references to infrastructure that no longer exists. None of these edits has a deploy surface.

- lib/cdo/honeybadger.rb: drop the pegasus project (id 34365) from get_recent_issues; the project is retired.
- lib/cdo/server_tools.rb: delete the ELB deregistration path. A read-only AWS check (2026-07-07) found zero classic ELBs; all three load balancers it targeted are gone. Delete the internal method, its caller-free wrapper deregister_frontends, and the call in deprovision_frontends, whose comment and prompt now describe only what it still does. Note: the whole ServerTools class has zero external references; deleting the rest is follow-up work.
- lib/cdo/sequel.rb: drop a commented-out logging line that instructed readers to start bin/pegasus-server.
- dashboard/lib/certificate_image.rb: drop a stale comment; the file never uses pegasus_dir.
- aws/.gitignore and the dockerignore generated from it: drop the .pegasus-built and .pegasus-up-to-date markers; nothing writes them.

Part 5/6 of the pegasus dead-code sweep (openspec change pegasus-dead-code-sweep, plan in #73702).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
stephenliang force-pushed the stephen/pegasus-sweep-5-refs branch from 698e849 to 93e778f Compare August 21, 2026 17:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL