FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Updated content from codeRIT to BrickHack by skyegallup · Pull Request #55 · codeRIT/coderit.github.io · GitHub

/ coderit.github.io Public

Updated content from codeRIT to BrickHack - #55

Merged
skyegallup merged 9 commits into
masterfrom
issue-54
Jul 1, 2021
ConversationCommits (9)ChecksFiles changed
Merged

Updated content from codeRIT to BrickHack#55
skyegallup merged 9 commits into
masterfrom
issue-54

Conversation

skyegallup commented Jun 29, 2021

Copy link
Copy Markdown
  • Updated club name, images, links, etc.
  • Replaced body content to better reflect our club's goals
  • Temporarily commented out Facebook group link and disabled "join our Discord" button

Fixes #54

skyegallup requested a review from peterkos June 29, 2021 01:43
skyegallup self-assigned this Jun 29, 2021

peterkos commented Jun 29, 2021

Copy link
Copy Markdown

I think we should add a little blurb above "more info coming soon" that highlights that BrickHack is our main event just to make the distinction clear for now!

peterkos approved these changes Jun 29, 2021
View reviewed changes

peterkos left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! see comment before this review

skyegallup commented Jun 29, 2021

Copy link
Copy Markdown
Author

@peterkos Does this work?

peterkos commented Jul 1, 2021

Copy link
Copy Markdown

@clairegallup I think we should add a link to BrickHack there as it's most likely people will click that to go to the site vs. scroll down more. I don't personally see the harm in putting the link again there (while also keeping it in the Events section below), thoughts?

skyegallup commented Jul 1, 2021

Copy link
Copy Markdown
Author

That makes sense. I'll do that and push my changes for a final review.

skyegallup commented Jul 1, 2021

Copy link
Copy Markdown
Author

Does this work?

skyegallup merged commit b997857 into master Jul 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

peterkos peterkos approved these changes

Assignees

skyegallup

Labels

content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL