#449 Update HTML lesson 1 example page to match the tutorial - #450
Open
louiechristie wants to merge 4 commits into
Open
louiechristie wants to merge 4 commits into
louiechristie wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
louiechristie
force-pushed
the
gh-pages
branch
from
ca388bc to
f167ac1
Compare
November 25, 2019 18:16
Copy link
Copy Markdown
Author
|
@MarckK can you review this pull request? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated HTML lesson 1 example page to match the tutorial.
Because it is confusing for students when the example page is different to what they have created with the tutorial.
Also, for testing with rbenv, I had to update old version of Ruby to version to 2.5.1 by cherry picking the commit from pull request #403, so this pull request also fixes issue #401.
(Later I upgraded to Ruby version 2.6.2 for testing using Netlify.)