FEATURE: add new public api, tests and docs. Typed dataTableArgument - #3047
Merged
DavertMik merged 3 commits intoSep 19, 2021
Merged
FEATURE: add new public api, tests and docs. Typed dataTableArgument#3047DavertMik merged 3 commits into
DavertMik merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@peterngtr @DavertMik review please. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks, i will check it today |
Sorry, something went wrong.
DavertMik
requested changes
Sep 17, 2021
DavertMik
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Please move out DataTableArgument from the core class and export it independently via index.js
Sorry, something went wrong.
Comment thread
lib/codecept.js
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@DavertMik review again, please |
Sorry, something went wrong.
DavertMik
requested changes
Sep 18, 2021
Comment thread
docs/bdd.md
Outdated
Arhell
approved these changes
Sep 18, 2021
Copy link
Copy Markdown
Contributor
|
Yes, that's it. Thank you! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Lack of typing DataTableArgument, it is difficult to work with this class using TS.
Some methods for working with the cucumber-like table are not implemented.
Description of this PR, which problem it solves:
Applicable plugins:
Type of change
Checklist: