fix: Prevent UnicodeDecodeError from non-UTF-8 git paths - #751
Open
sentry[bot] wants to merge 1 commit into
Open
fix: Prevent UnicodeDecodeError from non-UTF-8 git paths#751sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
❌ 1 Tests Failed:
To view more test analytics, go to the Test Analytics Dashboard |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a UnicodeDecodeError that occurred when codecov-cli attempted to decode git command output containing non-UTF-8 bytes, particularly in filenames or branch names.
The root cause was identified as the use of bare .decode() calls (which default to strict UTF-8) on subprocess.run stdout, leading to crashes when encountering invalid byte sequences (e.g., 0xc0).
The fix involves updating all relevant .decode() calls in codecov_cli/helpers/versioning_systems.py to explicitly use decode("utf-8", errors="surrogateescape"). This standard Python idiom for handling filesystem paths ensures that non-UTF-8 bytes are preserved as surrogate characters instead of raising an exception, allowing the CLI to gracefully process repositories with such names.
Fixes CLI-BD