FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added option to disable printing of gcov-out by nmoinvaz · Pull Request #305 · codecov/codecov-python · GitHub

This repository was archived by the owner on May 21, 2025. It is now read-only.
/ codecov-python Public archive

Added option to disable printing of gcov-out - #305

Merged
thomasrockhu merged 1 commit into
codecov:masterfrom
nmoinvaz:master
Dec 10, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Added option to disable printing of gcov-out#305
thomasrockhu merged 1 commit into
codecov:masterfrom
nmoinvaz:master

Conversation

nmoinvaz commented Dec 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is similar to the same option by the same name in the bash uploader. Any errors written out to stderr by gcov will still be output in the Popen call. This PR should also help with #168.

codecov Bot commented Dec 2, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #305 (b40cb0a) into master (5862842) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #305   +/-   ##
=====================================
  Coverage      88%    88%           
=====================================
  Files           2      2           
  Lines           9      9           
=====================================
  Hits            8      8           
  Misses          1      1

nmoinvaz commented Dec 2, 2020

Copy link
Copy Markdown
Contributor Author

@thomasrockhu it would be great to get this feature into a release. At work we have a large project with many sources files and the build logs get full easily with the gcov output. Thanks in advance!

thomasrockhu reviewed Dec 6, 2020
View reviewed changes
Comment thread codecov/__init__.py Outdated
Comment on lines +988 to +989
if codecov.gcov_out:
write(" Executing gcov (%s)" % cmd)

thomasrockhu Dec 6, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we should write this regardless

Suggested change
if codecov.gcov_out:
write(" Executing gcov (%s)" % cmd)
write(" Executing gcov (%s)" % cmd)

nmoinvaz Dec 6, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A few lines above, it says Processing gcov.. One of the reasons I thought it might not be necessary is that each of the gcov files is listed under Collecting reports.

Let me know if you would still like it printed.

Comment thread codecov/__init__.py Outdated
Comment thread codecov/__init__.py Outdated

nmoinvaz commented Dec 8, 2020

Copy link
Copy Markdown
Contributor Author

@thomasrockhu I have made some of the requested changes.

thomasrockhu merged commit 58032a4 into codecov:master Dec 10, 2020

nmoinvaz commented Dec 10, 2020

Copy link
Copy Markdown
Contributor Author

Thanks!

nmoinvaz commented Dec 11, 2020

Copy link
Copy Markdown
Contributor Author

With this PR our coverage build logs went from 426KB to 114KB.

dependabot Bot mentioned this pull request Mar 11, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
thomasrockhu thomasrockhu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL