Codecov Report

Merging #322 (7ce0645) into master (51469b0) will increase coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff          @@
##           master   #322   +/-   ##
=====================================
  Coverage      58%    58%           
=====================================
  Files           3      3           
  Lines         436    439    +3     
  Branches      106    107    +1     
=====================================
+ Hits          255    259    +4     
+ Misses        125    124    -1     
  Partials       56     56           

I think this is missing unit tests.

Thank you very much @nmoinvaz.
That is very true. As I commented in the discussions page, I don't really know how to add them. Is there any guidance?
I looked into the bash uploader test suite and they seem to have the tests there, however I could not figure out a way of porting the tests over, the python uploader tests seem much more complicated.

To me they look like they actually expect to run in the given CI, instead of just posting data that the codecov server can verify from existing builds (I can be very wrong here, I really had troubles understanding the existing test suite).

If you can guide me through the process, I am more than happy to add the missing tests.

Unit tests can be found in

It simply sets up the environment using example environment key value pairs. Then it ensures that the proper values are parsed from the environment variables after it runs run_cli().

Take a look at my PR for example:
https://github.com/codecov/codecov-python/pull/265/files

Yes, I did see this code, but it is exactly the code that I was having trouble to understand.
Specially the skip decorators were looking very mysterious, it looked to me like they were requiring the test suite to be executed inside the corresponding CI service...

But I think now I understand now what is happening... The decorators are there just to make sure the tests are not executed more than once, isn't it? Once the test runs, it changes the env vars, and then the decorators are there to make sure the same test does not run again?

I think now I might be able to give it a shot. Thank you (I should follow up shortly).

Tests added, hopefully they will pass in the CI, since I just ported them from the bash exporter 🤞

Good idea about using the bash ones. @thomasrockhu can you start the workflows?

LGTM, will deploy a new version sometime this week. Just a note, we will be deprecating support for this uploader in the next few months in favor of our new uploader