Fix script to handle property type changes for >2 versions - #132
Open
meldra wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Previously this was comparing both subsequent versions with the latest version, which means if the change conflicts with both earlier versions then we got a table row for each CodeMeta version processed for the tables. Since v2 will not immediately become unsupported due to the amount of adoption, this is necessary for now. At some point the future there may be an end of life process that requires the definitions relocate to elsewhere but there is no consensus yet.
Copy link
Copy Markdown
Contributor
Author
|
There is a temporary demo using the current scicodes clean pruned branch's .csv at https://codemeta.opinions.monster/terms/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
To be clear, the Makefile change that does this is not included in this PR. It is a change added only to my demo branch (the one that deploys the demo site) for the purposes of QA for this change. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this was comparing both subsequent versions with the latest version, which means if the change conflicts with both earlier versions then we got a table row for each CodeMeta version processed for the tables.
Since v2 will not immediately become unsupported due to the amount of adoption, this is necessary for now. At some point the future there may be an end of life process that requires the definitions relocate to elsewhere but there is no consensus yet.