This repository was archived by the owner on Oct 17, 2021. It is now read-only.
Update help output - #17
Merged
fuskovic merged 3 commits intoAug 4, 2020
Merged
fuskovic merged 3 commits into
fuskovic merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cmoog
approved these changes
Aug 4, 2020
creack
reviewed
Aug 4, 2020
creack
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
A couple of nit-picky details, but lgtm.
Sorry, something went wrong.
Comment thread
command_test.go
Outdated
Comment thread
help.go
Outdated
Comment thread
help.go
Outdated
Comment thread
command_test.go
Outdated
Comment thread
command_test.go
Outdated
creack
approved these changes
Aug 4, 2020
fuskovic
force-pushed
the
update-help-output-format
branch
from
a284572 to
6615750
Compare
August 4, 2020 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Updates the help output.
Why?
It looks like this :
Usage: coder users [subcommand] <flags> Aliases: [u usr]interact with user accounts Commands: ls - list all usersBut we want it to look like this:
Usage: coder users [subcommand] <flags> Aliases: u, usr Description: interact with user accounts Commands: ls - list all usersWere the tests updated?
Yes
Are they still passing?
Yes
=== RUN TestSubCmdAliases/s === RUN TestSubCmdAliases/sc === RUN TestSubCmdAliases/sub --- PASS: TestSubCmdAliases (0.00s) --- PASS: TestSubCmdAliases/s (0.00s) --- PASS: TestSubCmdAliases/sc (0.00s) --- PASS: TestSubCmdAliases/sub (0.00s) === RUN TestSubcmdAliasesInParentCmdHelpOutput --- PASS: TestSubcmdAliasesInParentCmdHelpOutput (0.00s) === RUN TestSubCmdHelpOutput === RUN TestSubCmdHelpOutput/subcmd_w/nested_subcmd. === RUN TestSubCmdHelpOutput/subcmd_w/no_nested_subcmds. --- PASS: TestSubCmdHelpOutput (0.00s) --- PASS: TestSubCmdHelpOutput/subcmd_w/nested_subcmd. (0.00s) --- PASS: TestSubCmdHelpOutput/subcmd_w/no_nested_subcmds. (0.00s) PASS ok go.coder.com/cli 0.177s