feat(testing): add code coverage - #2621
Merged
jsjoeio merged 2 commits intoJan 25, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jsjoeio
commented
Jan 22, 2021
Comment thread
ci/dev/test.sh
Outdated
Comment thread
lib/vscode/build/tsconfig.json
Outdated
Comment thread
lib/vscode/build/tsconfig.json
Outdated
Comment thread
package.json
Outdated
Comment thread
tsconfig.json
jsjoeio
marked this pull request as draft
January 22, 2021 17:30
jsjoeio
force-pushed
the
issue-2550-add-coverage
branch
3 times, most recently
from
ea14f81 to
73a8fda
Compare
January 22, 2021 17:44
jsjoeio
commented
Jan 22, 2021
Comment thread
package.json
| "@types/http-proxy": "^1.17.4", | ||
| "@types/js-yaml": "^3.12.3", | ||
| "@types/node": "^12.12.7", | ||
| "@types/node-fetch": "^2.5.7", |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Moved to ./test/package.json.
Sorry, something went wrong.
Comment thread
tsconfig.json
| "tsBuildInfoFile": "./.cache/tsbuildinfo", | ||
| "incremental": true, | ||
| "typeRoots": ["./node_modules/@types", "./typings"], | ||
| "typeRoots": ["./node_modules/@types", "./typings", "./test/node_modules/@types"], |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Sorry, something went wrong.
jsjoeio
marked this pull request as ready for review
January 22, 2021 17:45
jsjoeio
commented
Jan 22, 2021
Comment thread
ci/dev/test.sh
Outdated
jsjoeio
force-pushed
the
issue-2550-add-coverage
branch
2 times, most recently
from
7b1b3d5 to
d00dc17
Compare
January 22, 2021 20:49
jsjoeio
force-pushed
the
issue-2550-add-coverage
branch
from
d00dc17 to
05beccf
Compare
January 22, 2021 21:18
jsjoeio
force-pushed
the
issue-2550-add-coverage
branch
from
c5b820f to
ac127f6
Compare
January 25, 2021 18:14
code-asher
approved these changes
Jan 25, 2021
code-asher
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good!
Sorry, something went wrong.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solution made possible thanks to @code-asher