FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(testing): add playwright by jsjoeio · Pull Request #2643 · coder/code-server · GitHub

/ code-server Public

feat(testing): add playwright - #2643

Merged
jsjoeio merged 2 commits into
masterfrom
add-playwright
Feb 2, 2021
ConversationCommits (2)ChecksFiles changed
Merged

feat(testing): add playwright #2643
jsjoeio merged 2 commits into
masterfrom
add-playwright

Conversation

jsjoeio commented Jan 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds playwright for end-to-end testing. In ci, we now download the code-server artifact, run code-server in ci and then run tests against it.

Changes

  • add playwright to /test/package.json
  • add basic test for login page
  • update ci.yml test job to work with e2e

Additional Notes

Right now, yarn test runs both the unit and the e2e tests. This means it will fail locally if you do not have code-server running. In the future, we should consider separating the tests. We could have test:unit and test:e2e and then have separate jobs for each in ci.

Follow-up issue: #2646

Todos

  • remove pkill node in ci job
  • clean up commit messages

jsjoeio commented Jan 26, 2021
View reviewed changes
Comment thread .github/workflows/ci.yaml Outdated
jsjoeio self-assigned this Jan 28, 2021
jsjoeio commented Jan 28, 2021
View reviewed changes
Comment thread .github/workflows/ci.yaml Outdated
Comment thread .github/workflows/ci.yaml Outdated
Comment thread ci/images/playwright/Dockerfile Outdated
Comment thread test/e2e.test.ts
Comment thread test/e2e.test.ts Outdated
Comment thread test/package.json
Comment thread test/package.json
jsjoeio commented Jan 28, 2021
View reviewed changes
Comment thread .gitignore Outdated

jsjoeio commented Jan 28, 2021

Copy link
Copy Markdown
Contributor Author

The macos error looks like it was a network connection error:

jsjoeio mentioned this pull request Jan 28, 2021
Closed
jsjoeio marked this pull request as ready for review January 28, 2021 18:11
oxy reviewed Jan 28, 2021
View reviewed changes

oxy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks alright to me! Haven't worked much on testing so far - so you might want a second opinion.

Comment thread .gitignore Outdated
jsjoeio requested review from code-asher and oxy January 28, 2021 23:43
code-asher previously requested changes Jan 29, 2021
View reviewed changes

code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is quite exciting. 😄

Comment thread .github/workflows/ci.yaml Outdated
Comment thread .github/workflows/ci.yaml Outdated
code-asher reviewed Jan 29, 2021
View reviewed changes
Comment thread .github/workflows/ci.yaml Outdated
jsjoeio requested a review from code-asher January 29, 2021 18:15

jsjoeio commented Jan 29, 2021

Copy link
Copy Markdown
Contributor Author

Seeing strange errors in the macos release

jsjoeio commented Jan 29, 2021

Copy link
Copy Markdown
Contributor Author

Re-running tests

nhooyr approved these changes Feb 1, 2021
View reviewed changes

nhooyr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very nice! :)

Comment thread .github/workflows/ci.yaml Outdated
jsjoeio dismissed code-asher’s stale review February 2, 2021 18:01

I made your changes and Anmol approved!

jsjoeio merged commit 4c6ad04 into master Feb 2, 2021
jsjoeio deleted the add-playwright branch February 2, 2021 18:02
jsjoeio mentioned this pull request Feb 10, 2021
Closed
jsjoeio added the testing Anything related to testing label May 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

oxy Awaiting requested review from oxy
code-asher Awaiting requested review from code-asher
1 more reviewer
nhooyr nhooyr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jsjoeio

Labels

testing Anything related to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL