feat(testing): add unit tests for common/util - #2671
Merged
jsjoeio merged 4 commits intoFeb 8, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jsjoeio
force-pushed
the
add-unit-tests
branch
from
6dda885 to
940f14d
Compare
February 3, 2021 23:58
jsjoeio
marked this pull request as ready for review
February 4, 2021 17:41
oxy
suggested changes
Feb 4, 2021
oxy
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
PR looks good! Might have to combine the two comments in test/package.json into a single line to avoid future issues, though.
Sorry, something went wrong.
Comment thread
test/package.json
jsjoeio
force-pushed
the
add-unit-tests
branch
from
1640869 to
4f6efce
Compare
February 4, 2021 22:18
oxy
approved these changes
Feb 8, 2021
oxy
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds several unit tests for the src/common/util functions.
Screenshot
It increases our code coverage (Lines) from 46.88% to 49.53% (↑ 2.65%)
🟩 100% coverage for src/common/util
TODOS