feat(testing): add unit tests for src/common/http - #2702
Merged
jsjoeio merged 1 commit intoFeb 10, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
oxy
suggested changes
Feb 9, 2021
oxy
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
I think BadRequest should only need to appear once.
Sorry, something went wrong.
Comment thread
test/http.test.ts
Outdated
jsjoeio
force-pushed
the
add-unit-tests-http
branch
from
7055dba to
c7c851d
Compare
February 9, 2021 20:13
oxy
approved these changes
Feb 10, 2021
oxy
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few tests for src/common/http. Note: intentionally selected add-unit-tests-constants as the base since I branched off it.
Screenshot
It increases our code coverage (Lines) from 49.83% to 50.09% (↑ 0.0.26%).
🟩 100% Line coverage (last 100) for src/node/http.ts