feat(testing): add unit tests for emitter - #2715
Merged
jsjoeio merged 2 commits intoFeb 23, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
oxy
reviewed
Feb 12, 2021
Comment thread
test/emitter.test.ts
Outdated
jsjoeio
commented
Feb 18, 2021
Comment thread
test/emitter.test.ts
Outdated
jsjoeio
force-pushed
the
add-tests-emitter
branch
from
1896154 to
5e287ad
Compare
February 18, 2021 23:56
code-asher
approved these changes
Feb 22, 2021
jsjoeio
marked this pull request as draft
February 22, 2021 17:01
jsjoeio
force-pushed
the
add-tests-emitter
branch
from
5e287ad to
325a1d8
Compare
February 22, 2021 20:44
jsjoeio
marked this pull request as ready for review
February 22, 2021 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few tests for src/common/emitter.ts.
Screenshot
It increases our code coverage (Lines) from 50.09% to 50.26% (↑ 0.17%).
🟩 100% Line coverage (last 100) for src/common/emitter.ts and also 100% coverage for src/common
TODOS