FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(testing): add unit tests for register by jsjoeio · Pull Request #2719 · coder/code-server · GitHub

/ code-server Public

feat(testing): add unit tests for register - #2719

Merged
jsjoeio merged 22 commits into
masterfrom
add-tests-register
Feb 26, 2021
ConversationCommits (22)ChecksFiles changed
Merged

feat(testing): add unit tests for register#2719
jsjoeio merged 22 commits into
masterfrom
add-tests-register

Conversation

jsjoeio commented Feb 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds a few tests for src/browser/register.ts.

Screenshot

It increases our code coverage (Lines) from 50.09% to 51.13% (↑ 1.04%).
🟩 100% Line coverage (last 100) for src/browser/register.ts

TODOs

  • rebase branch onto master
  • address feedback
  • refactor based on Asher's suggestion
  • add test for else statement in register

jsjoeio added this to the v3.8.2 milestone Feb 12, 2021
jsjoeio self-assigned this Feb 12, 2021
jsjoeio marked this pull request as ready for review February 12, 2021 00:04
jsjoeio requested review from code-asher and oxy February 12, 2021 00:04
jsjoeio marked this pull request as draft February 12, 2021 16:43
jsjoeio marked this pull request as ready for review February 12, 2021 17:10
oxy approved these changes Feb 12, 2021
View reviewed changes

oxy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! Your choice on if you want a second opinion from asher on this one; I'm not too confident in my TS just yet 😅

jsjoeio commented Feb 12, 2021

Copy link
Copy Markdown
Contributor Author

I'll play it safe since we're releasing today - @code-asher would love an 👀 on this one!

jsjoeio modified the milestones: v3.9.0, v3.9.1 Feb 12, 2021
jsjoeio commented Feb 18, 2021
View reviewed changes
Comment thread test/util.test.ts
Comment thread src/browser/register.ts Outdated
Comment thread src/browser/register.ts Outdated
Comment thread package.json
jsjoeio mentioned this pull request Feb 18, 2021
Closed
jsjoeio marked this pull request as draft February 18, 2021 22:17
jsjoeio marked this pull request as ready for review February 18, 2021 23:57
code-asher requested changes Feb 22, 2021
View reviewed changes
Comment thread src/browser/register.ts Outdated
Comment thread test/emitter.test.ts
Comment thread test/register.test.ts Outdated
Comment thread test/register.test.ts Outdated
Comment thread test/register.test.ts Outdated
Comment thread src/browser/register.ts Outdated
jsjoeio marked this pull request as draft February 22, 2021 17:38
Base automatically changed from add-tests-emitter to master February 23, 2021 17:02
jsjoeio force-pushed the add-tests-register branch 2 times, most recently from 14ad29a to 909d425 Compare February 23, 2021 23:03
jsjoeio marked this pull request as ready for review February 23, 2021 23:27
jsjoeio commented Feb 23, 2021
View reviewed changes
Comment thread test/helpers.ts
Comment thread test/register.test.ts
jsjoeio requested review from a team and code-asher February 23, 2021 23:31
jsjoeio added 17 commits February 26, 2021 11:51
feat(testing): add register test
06aeca0
refactor: use logger in serviceworker
a9f88af
feat: test failure to register service worker
44b9874
refactor: add handleRegisterServiceWorker fn
21f577d
feat(test): add test handleRegisterServiceWorker
38891de
refactor(register): use logError instead of logger
7ef630f
refactor: use same syntax as logger spy
a44a514
refactor: use LogModule from Asher in tests
027e8e5
refactor: move loggerModule into helpers
711abd8
refactor: dont use actual logger in helper
1470ff2
refactor: hoist jest.mock in constants
1c737f1
refactor: use loggerModule in util
cb4185b
refactor: update mocking logger in register test
e6a324b
feat(register): add test when navigator undefined
b232dcb
feat: add test for catching errors in Emitter
80a1800
chore(testing): add service-worker-mock
46226ea
feat: add logs to serviceWorker
ee0973c
jsjoeio requested a review from a team as a code owner February 26, 2021 19:04
code-asher requested changes Feb 26, 2021
View reviewed changes
Comment thread test/emitter.test.ts Outdated
jsjoeio requested a review from code-asher February 26, 2021 23:00
code-asher approved these changes Feb 26, 2021
View reviewed changes

code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good!!

Comment thread test/register.test.ts Outdated

jsjoeio commented Feb 26, 2021

Copy link
Copy Markdown
Contributor Author

CI only failed due to #2480

jsjoeio merged commit 726f694 into master Feb 26, 2021
jsjoeio deleted the add-tests-register branch February 26, 2021 23:47
jsjoeio added the testing Anything related to testing label May 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

code-asher code-asher approved these changes
+1 more reviewer
oxy oxy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jsjoeio

Labels

testing Anything related to testing

Projects

None yet

Milestone

v3.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL