Remove fs-extra - #2889
Merged
code-asher merged 3 commits intoMar 16, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jawnsy
previously approved these changes
Mar 15, 2021
code-asher
force-pushed
the
remove-fs-extra
branch
from
a71cc35 to
d5fb9bb
Compare
March 15, 2021 21:33
Copy link
Copy Markdown
Member
Author
|
Realized I didn't need my own unlinkf and rmdir with recursive works on files so I just pushed a change to use rmdir instead. Although semantically it feels a bit weird. |
Sorry, something went wrong.
jsjoeio
previously approved these changes
Mar 16, 2021
jsjoeio
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sorry, something went wrong.
Remove the Mac directory copy instead of refactoring it since we've had this for a long time now and I think it's safe to assume that users running code-server on Mac don't have the old directory anymore.
code-asher
force-pushed
the
remove-fs-extra
branch
from
1164300 to
964ebe8
Compare
March 16, 2021 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's more detail in the commits.