Remove unmaintained CI images and update release workflow - #3147
Conversation
jsjoeio
left a comment
There was a problem hiding this comment.
Thanks for picking this up so quickly!
Sorry for deleting that without realizing we used it here 😅
Two comments! But overall looks great!
Sorry, something went wrong.
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| name: npm-package |
There was a problem hiding this comment.
What is this name environment variable used for? (Just curious)
Sorry, something went wrong.
oxy
left a comment
There was a problem hiding this comment.
I can't request changes on my own PR so don't merge yet, I reviewed it myself and caught something 😅
Sorry, something went wrong.
| - name: Download npm package | ||
| uses: actions/download-artifact@v2 | ||
| with: | ||
| args: ./ci/steps/publish-npm.sh | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| name: npm-package |
There was a problem hiding this comment.
Took a second look and need to fix this; npm-package is produced by the ci.yaml workflow, we need to fetch it from there, this won't work.
Sorry, something went wrong.
jsjoeio
left a comment
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
⚠️ This needs to be merged before we make a release!
ci/images/debian10 was removed in a previous PR, but we still used it in our publish flow... this should fix that, and also update our documentation to stop referring to those images.
Closes #3142.