chore(ci): migrate from hub to gh - #3168
Merged
oxy merged 1 commit intoApr 19, 2021
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
jsjoeio
approved these changes
Apr 19, 2021
jsjoeio
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Fantastic work! 🎉
Sorry, something went wrong.
Comment thread
ci/build/release-prep.sh
| exit | ||
| fi | ||
|
|
||
| # Check that gh is authenticated |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice addition!
Sorry, something went wrong.
Comment thread
ci/lib.sh
| # example: v3.9.3 | ||
| local version_branch="v$VERSION" | ||
| artifacts_url=$(curl -fsSL "$workflow_runs_url" | jq -r ".workflow_runs[] | select(.head_branch == \"$version_branch\") | .artifacts_url" | head -n 1) | ||
| artifacts_url=$(gh api "$workflow_runs_url" | jq -r ".workflow_runs[] | select(.head_branch == \"$version_branch\") | .artifacts_url" | head -n 1) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🔥
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes -
In addition to moving our two hub calls to gh, I also replaced the curl calls that depend on GITHUB_TOKEN being set in ci/lib.sh with gh api calls instead; the benefit is that this also allows alternative auth (stored in ~/.config/gh/hosts.yml instead of env).
Closes #2960.