FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revamp debugging section by code-asher · Pull Request #3224 · coder/code-server · GitHub

/ code-server Public

Revamp debugging section - #3224

Merged
code-asher merged 1 commit into
coder:mainfrom
code-asher:issue-logs
Apr 26, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Revamp debugging section#3224
code-asher merged 1 commit into
coder:mainfrom
code-asher:issue-logs

Conversation

code-asher commented Apr 26, 2021

Copy link
Copy Markdown
Member
  • Most people leave the logs out so add a section for them in the issue
    template.
  • Remove the VS Code logs because those get sent to stdout now and will
    show up in our logs.
  • Separate browser console and network.

Revamp debugging section
a5674d9 
- Most people leave the logs out so add a section for them in the issue
  template.
- Remove the VS Code logs because those get sent to stdout now and will
  show up in our logs.
- Separate browser console and network.
code-asher requested a review from a team as a code owner April 26, 2021 16:11

codecov Bot commented Apr 26, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3224 (95f65d9) into main (4fd39b2) will not change coverage.
The diff coverage is n/a.

❗ Current head 95f65d9 differs from pull request most recent head a5674d9. Consider uploading reports for the commit a5674d9 to get more accurate results

@@           Coverage Diff           @@
##             main    #3224   +/-   ##
=======================================
  Coverage   46.81%   46.81%           
=======================================
  Files          23       23           
  Lines        1194     1194           
  Branches      237      237           
=======================================
  Hits          559      559           
  Misses        451      451           
  Partials      184      184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd39b2...a5674d9. Read the comment docs.

oxy reviewed Apr 26, 2021
View reviewed changes

oxy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, but I'm confused about the minor inconsistency with ~/.local/share/code-server/logs

Comment thread docs/FAQ.md
information from the following places:

1. The most recent files from `~/.local/share/code-server/coder-logs`.
2. The most recently created directory in the `~/.local/share/code-server/logs` directory.

oxy Apr 26, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Line removed here, but still present in the issue template;

Comment thread .github/ISSUE_TEMPLATE/bug-report.md
Once this is done, replicate the issue you're having then collect logging
information from the following places:

1. The most recent files from ~/.local/share/code-server/coder-logs.

oxy Apr 26, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Line added here, but removed from the debugging FAQ;

code-asher commented Apr 26, 2021

Copy link
Copy Markdown
Member Author

Ah yeah it looks a bit confusing because we have the unfortunate names of logs and coder-logs.

~/.local/share/code-server/logs < was removed
~/.local/share/code-server/coder-logs < was kept

oxy commented Apr 26, 2021

Copy link
Copy Markdown

Oh lordy - I can't believe I missed the coder- in there! My bad.

oxy approved these changes Apr 26, 2021
View reviewed changes

oxy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good!

code-asher merged commit f746212 into coder:main Apr 26, 2021
code-asher deleted the issue-logs branch April 26, 2021 17:56
jsjoeio added this to the v3.9.4 milestone Apr 26, 2021
jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
oxy oxy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Related to maintenance or clean up

Projects

None yet

Milestone

v3.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL