FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(readme): refactor to use codecov shield by jsjoeio · Pull Request #3227 · coder/code-server · GitHub

/ code-server Public

docs(readme): refactor to use codecov shield - #3227

Merged
repo-ranger[bot] merged 2 commits into
mainfrom
jsjoeio/fix-coverage-shield
Apr 26, 2021
ConversationCommits (2)ChecksFiles changed
Merged

docs(readme): refactor to use codecov shield#3227
repo-ranger[bot] merged 2 commits into
mainfrom
jsjoeio/fix-coverage-shield

Conversation

jsjoeio commented Apr 26, 2021

Copy link
Copy Markdown
Contributor

This PR removes our previous workflow of adding a badge using a 3P package to using a dynamic one with codecov.

jsjoeio requested a review from a team as a code owner April 26, 2021 21:14
jsjoeio changed the title jsjoeio/fix-coverage-shield docs(readme): refactor to use codecov shield Apr 26, 2021
jawnsy approved these changes Apr 26, 2021
View reviewed changes

jawnsy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice!

jsjoeio commented Apr 26, 2021
View reviewed changes
Comment thread README.md
# code-server · [!["GitHub Discussions"](https://img.shields.io/badge/%20GitHub-%20Discussions-gray.svg?longCache=true&logo=github&colorB=purple)](https://github.com/cdr/code-server/discussions) [!["Join us on Slack"](https://img.shields.io/badge/join-us%20on%20slack-gray.svg?longCache=true&logo=slack&colorB=brightgreen)](https://cdr.co/join-community) [![Twitter Follow](https://img.shields.io/twitter/follow/CoderHQ?label=%40CoderHQ&style=social)](https://twitter.com/coderhq)

![Lines](https://img.shields.io/badge/Coverage-51.47%25-green.svg)
[![codecov](https://codecov.io/gh/cdr/code-server/branch/main/graph/badge.svg?token=5iM9farjnC)](https://codecov.io/gh/cdr/code-server)

jsjoeio Apr 26, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Markdown provided by Codecov. Don't worry, this token isn't used for uploading coverage data to Codecov. I believe it's just used for the badge.

jsjoeio self-assigned this Apr 26, 2021
jsjoeio added docs Documentation related testing Anything related to testing labels Apr 26, 2021

codecov Bot commented Apr 26, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3227 (76dff60) into main (d6cdeab) will not change coverage.
The diff coverage is n/a.

❗ Current head 76dff60 differs from pull request most recent head cb5997b. Consider uploading reports for the commit cb5997b to get more accurate results

@@           Coverage Diff           @@
##             main    #3227   +/-   ##
=======================================
  Coverage   46.81%   46.81%           
=======================================
  Files          23       23           
  Lines        1194     1194           
  Branches      237      237           
=======================================
  Hits          559      559           
  Misses        451      451           
  Partials      184      184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6cdeab...cb5997b. Read the comment docs.

jsjoeio added this to the v3.9.4 milestone Apr 26, 2021
repo-ranger Bot merged commit 85ded73 into main Apr 26, 2021
repo-ranger Bot deleted the jsjoeio/fix-coverage-shield branch April 26, 2021 21:27
jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
jawnsy jawnsy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jsjoeio

Labels

chore Related to maintenance or clean up docs Documentation related testing Anything related to testing

Projects

None yet

Milestone

v3.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL