FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(faq): add entry for accessing OSX folders by bpmct · Pull Request #3247 · coder/code-server · GitHub

/ code-server Public

docs(faq): add entry for accessing OSX folders - #3247

Merged
bpmct merged 1 commit into
coder:mainfrom
bpmct:osx-folders
Apr 29, 2021
ConversationCommits (1)ChecksFiles changed
Merged

docs(faq): add entry for accessing OSX folders#3247
bpmct merged 1 commit into
coder:mainfrom
bpmct:osx-folders

Conversation

bpmct commented Apr 28, 2021

Copy link
Copy Markdown
Member

the real credit goes to @noahsbwilliams for discovering and sharing this in #2794. I figured it should mandate a FAQ entry since it is a known issue

bpmct requested a review from a team as a code owner April 28, 2021 00:41

codecov Bot commented Apr 28, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3247 (5c59c79) into main (9f7ceef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3247   +/-   ##
=======================================
  Coverage   46.90%   46.90%           
=======================================
  Files          23       23           
  Lines        1196     1196           
  Branches      237      237           
=======================================
  Hits          561      561           
  Misses        451      451           
  Partials      184      184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7ceef...5c59c79. Read the comment docs.

jawnsy approved these changes Apr 28, 2021
View reviewed changes

jawnsy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for this! It seems good to me, but I'm not a Mac person so please wait for @jsjoeio to take a look 😄

jawnsy requested a review from jsjoeio April 28, 2021 01:14
jsjoeio approved these changes Apr 28, 2021
View reviewed changes

jsjoeio left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Thanks for adding this @bpmct 🙌

Feel free to merge!

jsjoeio changed the title add FAQ entry for accessing OSX folders docs(faq): add entry for accessing OSX folders Apr 28, 2021
jsjoeio added the docs Documentation related label Apr 28, 2021
jsjoeio added this to the v3.9.4 milestone Apr 28, 2021

noahsbwilliams commented Apr 29, 2021

Copy link
Copy Markdown

Glad I could help! This permissions scheme sure doesn't make it easy...

bpmct merged commit 6dace0f into coder:main Apr 29, 2021
bpmct deleted the osx-folders branch April 29, 2021 17:29
jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
jawnsy jawnsy approved these changes
jsjoeio jsjoeio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

bpmct

Labels

chore Related to maintenance or clean up docs Documentation related

Projects

None yet

Milestone

v3.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL